linux-kernel - Re: [PATCHv3 4/4] media: imx: Use dedicated format handler for i.MX7/8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Nov 2021 09:54:28 +0000
From:   "Rui Miguel Silva" <rmfrfs@...il.com>
To:     "Philipp Zabel" <p.zabel@...gutronix.de>,
        "Dorota Czaplejewicz" <dorota.czaplejewicz@...i.sm>,
        "Steve Longerbeam" <slongerbeam@...il.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Fabio Estevam" <festevam@...il.com>,
        "NXP Linux Team" <linux-imx@....com>,
        <linux-media@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...i.sm>,
        <phone-devel@...r.kernel.org>
Cc:     "Laurent Pinchart" <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCHv3 4/4] media: imx: Use dedicated format handler for
 i.MX7/8

Hi Philipp,
On Wed Nov 3, 2021 at 12:32 PM WET, Philipp Zabel wrote:

> On Tue, 2021-10-19 at 14:14 +0200, Dorota Czaplejewicz wrote:
> > This splits out a format handler which takes into account
> > the capabilities of the i.MX7/8 video device,
> > as opposed to the default handler compatible with both i.MX5/6 and i.MX7/8.
> > 
> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@...i.sm>
>
> Cc: Rui & Laurent
>
> Looks sane to me, but I'd like someone with i.MX7/8 media experience to
> have a look at this.

Thanks for the CC, this really went off of my radar. I will try to
take a look at it, but one of the comments on the first patch:

"The use of `v4l2_fill_pixfmt` comes with the downside of breaking
10-bit Bayer formats, or at least until my other series gets accepted
(Subject: "media: Add 16-bit Bayer formats". Sorry, I don't have the
message id.)."

made me wonder if that series was already accepted? without it this
will break the warp7 setup.

------
Cheers,
     Rui
>
> Thread at
> https://lore.kernel.org/linux-media/20211019120047.827915-1-dorota.czaplejewicz@puri.sm/
>
> regards
> Philipp