linux-kernel - Re: [PATCH] PCI: vmd: Remove duplicated include in vmd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYPA5rFIqYBCek+u@rocinante>
Date:   Thu, 4 Nov 2021 12:15:50 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Nirmal Patel <nirmal.patel@...ux.intel.com>,
        Jonathan Derrick <jonathan.derrick@...ux.dev>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, jiabing.wan@...com
Subject: Re: [PATCH] PCI: vmd: Remove duplicated include in vmd.c

Hi,

[...]
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -10,7 +10,6 @@
>  #include <linux/irq.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/device.h>
>  #include <linux/msi.h>
>  #include <linux/pci.h>
>  #include <linux/pci-acpi.h>

Wan, thank you for reporting this!

Bjorn, the patch I sent earlier:

  https://lore.kernel.org/all/20211013003145.1107148-1-kw@linux.com/

Accidentally left the include at the top that was intended to me moved to
be before the linux/msi.h to reflect previous order of the asm/device.h and
asm/msi.h had.

I must have forgotten to remove the one from the top later.  Sincere
apologies!

I can send an update, or we can squeeze these two patches together.  Sorry for
adding you more work to do.

	Krzysztof