linux-kernel - [PATCH v3] serial: 8250: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211104114754.30983-1-yao.jing2@zte.com.cn>
Date:   Thu,  4 Nov 2021 11:47:54 +0000
From:   cgel.zte@...il.com
To:     johan@...nel.org
Cc:     andrew@...id.au, cgel.zte@...il.com, fancer.lancer@...il.com,
        gregkh@...uxfoundation.org, jirislaby@...nel.org, joe@...ches.com,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        macro@...am.me.uk, pali@...nel.org, yao.jing2@....com.cn,
        zealci@....com.cn
Subject: [PATCH v3] serial: 8250: replace snprintf in show functions with sysfs_emit

From: Jing Yao <yao.jing2@....com.cn>

coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Jing Yao <yao.jing2@....com.cn>
---

Changes since v1 & v2:
 - Remove excess and wrong parameter 'PAGE_SIZE' in sysfs_emit function.
 - Revise the wrong patch Subject.

 drivers/tty/serial/8250/8250_port.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 5775cbff8f6e..3d58f383152e 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -3099,7 +3099,7 @@ static ssize_t rx_trig_bytes_show(struct device *dev,
 	if (rxtrig_bytes < 0)
 		return rxtrig_bytes;
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", rxtrig_bytes);
+	return sysfs_emit(buf, "%d\n", rxtrig_bytes);
 }
 
 static int do_set_rxtrig(struct tty_port *port, unsigned char bytes)
-- 
2.25.1