linux-kernel - Re: [PATCH v2] scsi: scsi_debug: fix type in min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70683ce5-cc77-ebc1-b534-7c2d3a92d715@oracle.com>
Date:   Thu, 4 Nov 2021 09:54:22 -0400
From:   George Kennedy <george.kennedy@...cle.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     gregkh@...uxfoundation.org, jejb@...ux.ibm.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [PATCH v2] scsi: scsi_debug: fix type in min_t to avoid stack OOB

Hi Martin,

On 11/3/2021 9:59 PM, Martin K. Petersen wrote:
> George,
>
>> Change min_t() to use type "unsigned int" instead of type "int" to
>> avoid stack out of bounds. With min_t() type "int" the values get sign
>> extended and the larger value gets used causing stack out of bounds.
> This needs to be reconciled with the following commits:
>
> f347c26836c2 scsi: scsi_debug: Fix out-of-bound read in resp_report_tgtpgs()
> 4e3ace0051e7 scsi: scsi_debug: Fix out-of-bound read in resp_readcap16()

The proposed patch should supersede the above commits.

George
>
> Thanks!
>