linux-kernel - Re: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3209bc4b-bde5-2e7e-4a91-429d2e83905e@infradead.org>
Date:   Thu, 4 Nov 2021 07:55:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Cc:     Wells Lu <wellslutw@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Subject: Re: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

On 11/4/21 5:59 AM, Andrew Lunn wrote:
> On Thu, Nov 04, 2021 at 05:31:57AM +0000, Wells Lu 呂芳騰 wrote:
>> Hi,
>>
>> Thanks a lot for review.
>>
>>>
>>>> config NET_VENDOR_SUNPLUS
>>>> 	bool "Sunplus devices"
>>>> 	default y
>>>> 	depends on ARCH_SUNPLUS
>>>
>>> Does it actually depend on ARCH_SUNPLUS? What do you make use of?
>>
>> ARCH_SUNPLUS will be defined for Sunplus family series SoC.
>> Ethernet devices of Sunplus are designed and used for Sunplus SoC.
>> So far, only two SoC of Sunplus have the network device.
>> I'd like to show up the selection only for Sunplus SoC.
> 
> So it does not actually depend on ARCH_SUNPLUS. There are a few cases
> where drivers have needed to call into arch specific code, which stops
> them building for any other arch.
> 
>>> Ideally, you want it to also build with COMPILE_TEST, so that the driver gets
>>> build by 0-day and all the other build bots.
>>
>> I am not sure if this is mandatory or not.
>> Should I add COMPILE_TEST as below?
>>
>> 	depends on ARCH_SUNPLUS | COMPILE_TEST
> 
> Yes.

Yes, but use "||" instead of one "|".

> 
>> Yes, the device is now only for Sunplus SP7021 SoC.
>> Devices in each SoC may have a bit difference because of adding new
>> function or improving something.
> 
> If it will compile with COMPILE_TEST on x86, mips, etc, you should
> allow it to compile with COMPILE_TEST. You get better compile testing
> that way.
> 
>       Andrew
> 


-- 
~Randy