linux-kernel - Re: [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8be3ee89-7fa9-4611-3fda-c152ca9fa444@quicinc.com>
Date:   Thu, 4 Nov 2021 09:54:11 +0800
From:   Fenglin Wu <quic_fenglinw@...cinc.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <sboyd@...nel.org>, Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <collinsd@...eaurora.org>, <subbaram@...eaurora.org>
Subject: Re: [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to
 YAML format


On 2021/11/4 6:20, Bjorn Andersson wrote:
> On Mon 01 Nov 23:57 PDT 2021, Fenglin Wu wrote:
> [..]
>> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>> new file mode 100644
>> index 0000000..05bb114
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
>> @@ -0,0 +1,122 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/spmi/qcom,spmi-pmic-arb.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm SPMI PMIC Arbiter
>> +
>> +maintainers:
>> +  - Fenglin Wu <quic_fenglinw@...cinc.com>
>> +
>> +description: |
>> +  The SPMI PMIC Arbiter is found on Snapdragon chipsets. It is an SPMI
>> +  controller with wrapping arbitration logic to allow for multiple
>> +  on-chip devices to control a single SPMI master.
>> +
>> +  The PMIC Arbiter can also act as an interrupt controller, providing
>> +  interrupts to slave devices.
>> +
>> +  See Documentation/devicetree/bindings/spmi/spmi.yaml for the generic
>> +  SPMI controller binding requirements for child nodes.
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^qcom,spmi@.*"
> Node names should never contain "qcom,". Seems the agreed upon node
> named should be "spmi@.*".
>
> The rest looks like a reasonable conversion to me.
>
> [..]
Thanks, I will update it in patch V2.
>> +examples:
>> +  - |
>> +    qcom,spmi@...cf000 {
> Regards,
> Bjorn