linux-kernel - Re: [PATCH 1/2] psi: Remove repeated verbose comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYQPL4exZUP2eruI@cmpxchg.org>
Date:   Thu, 4 Nov 2021 12:49:51 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Liu Xinpeng <liuxp11@...natelecom.cn>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        juri.lelli@...hat.com, zhouchengming@...edance.com,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/2] psi: Remove repeated verbose comment

On Mon, Oct 25, 2021 at 11:46:25AM +0800, Liu Xinpeng wrote:
> Comment in function psi_task_switch,there are two same lines.
> ...
> * runtime state, the cgroup that contains both tasks
> * runtime state, the cgroup that contains both tasks
> ...
> 
> Signed-off-by: Liu Xinpeng <liuxp11@...natelecom.cn>

Acked-by: Johannes Weiner <hannes@...xchg.org>

Peter, could you please take this through -tip?

> ---
>  kernel/sched/psi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1652f2b..526af84 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
>  		/*
>  		 * When switching between tasks that have an identical
>  		 * runtime state, the cgroup that contains both tasks
> -		 * runtime state, the cgroup that contains both tasks
>  		 * we reach the first common ancestor. Iterate @next's
>  		 * ancestors only until we encounter @prev's ONCPU.
>  		 */