linux-kernel - Re: [PATCH] arm64: cpufeature: Export this_cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Nov 2021 10:50:32 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     will@...nel.org, arnd@...nel.org, catalin.marinas@....com,
        gregkh@...uxfoundation.org, anshuman.khandual@....com,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] arm64: cpufeature: Export this_cpu_has_cap helper

On Wed, Nov 03, 2021 at 10:12:56PM +0000, Suzuki K Poulose wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Export the this_cpu_has_cap() for use by modules. This is
> used by TRBE driver. Without this patch, TRBE will fail
> to build as a module :
> 
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")
> Cc: Will Deacon <will@...nel.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> [ change to EXPORT_SYMBOL_GPL ]
> Acked-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> ---
>  arch/arm64/kernel/cpufeature.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f8a3067d10c6..82e68c69bb99 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2839,6 +2839,7 @@ bool this_cpu_has_cap(unsigned int n)
>  
>  	return false;
>  }
> +EXPORT_SYMBOL_GPL(this_cpu_has_cap);
>

I have applied this patch.

Thanks
Mathieu

>  /*
>   * This helper function is used in a narrow window when,
> -- 
> 2.25.4
>