linux-kernel - Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYQQIu6Xi/iEEb7f@kroah.com>
Date:   Thu, 4 Nov 2021 17:53:54 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yang Shi <shy828301@...il.com>
Cc:     naoya.horiguchi@....com, hughd@...gle.com,
        kirill.shutemov@...ux.intel.com, willy@...radead.org,
        osalvador@...e.de, peterx@...hat.com, akpm@...ux-foundation.org,
        stable@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [stable 5.10 PATCH] mm: hwpoison: remove the unnecessary THP
 check

On Wed, Nov 03, 2021 at 10:46:24AM +0100, Greg KH wrote:
> On Mon, Nov 01, 2021 at 12:48:56PM -0700, Yang Shi wrote:
> > commit c7cb42e94473aafe553c0f2a3d8ca904599399ed upstream.
> > 
> > When handling THP hwpoison checked if the THP is in allocation or free
> > stage since hwpoison may mistreat it as hugetlb page.  After commit
> > 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> > handling") the problem has been fixed, so this check is no longer
> > needed.  Remove it.  The side effect of the removal is hwpoison may
> > report unsplit THP instead of unknown error for shmem THP.  It seems not
> > like a big deal.
> > 
> > The following patch "mm: filemap: check if THP has hwpoisoned subpage
> > for PMD page fault" depends on this, which fixes shmem THP with
> > hwpoisoned subpage(s) are mapped PMD wrongly.  So this patch needs to be
> > backported to -stable as well.
> > 
> > Link: https://lkml.kernel.org/r/20211020210755.23964-2-shy828301@gmail.com
> > Signed-off-by: Yang Shi <shy828301@...il.com>
> > Suggested-by: Naoya Horiguchi <naoya.horiguchi@....com>
> > Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>
> > Cc: Hugh Dickins <hughd@...gle.com>
> > Cc: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Cc: Matthew Wilcox <willy@...radead.org>
> > Cc: Oscar Salvador <osalvador@...e.de>
> > Cc: Peter Xu <peterx@...hat.com>
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > ---
> > mm-filemap-check-if-thp-has-hwpoisoned-subpage-for-pmd-page-fault.patch
> > depends on this one.
> 
> Both now queued up, thanks.

This breaks the build, see:
	https://lore.kernel.org/r/acabc414-164b-cd65-6a1a-cf912d8621d7@roeck-us.net

so I'm going to drop both of these now.  Please fix this up and resend a
tested series.

thanks,

greg k-h