linux-kernel - Re: [PATCH] arm64: Track no early_pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb6fe11-c10a-a373-9288-d44a5ba976fa@quicinc.com>
Date:   Thu, 4 Nov 2021 13:57:03 -0400
From:   Qian Cai <quic_qiancai@...cinc.com>
To:     Mike Rapoport <rppt@...nel.org>
CC:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: Track no early_pgtable_alloc() for kmemleak

On 11/4/21 1:06 PM, Mike Rapoport wrote:
> I think I'll be better to rename MEMBLOCK_ALLOC_KASAN to, say,
> MEMBLOCK_ALLOC_NOKMEMLEAK and use that for both KASAN and page table cases.

Okay, that would look a bit nicer.

> But more generally, we are going to hit this again and again.
> Couldn't we add a memblock allocation as a mean to get more memory to
> kmemleak::mem_pool_alloc()?

For the last 5 years, this is the second time I am ware of this kind of
issue just because of the 64KB->4KB switch on those servers, although I
agree it could happen again in the future due to some new debugging
features etc. I don't feel a strong need to rewrite it now though. Not
sure if Catalin saw things differently. Anyway, Mike, do you agree that
we could rewrite that separately in the future?