linux-kernel - Re: perf build broken looking for bpf/{libbpf,bpf}.h after merge with upstream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYQiXnUxlOoWMdwZ@kernel.org>
Date:   Thu, 4 Nov 2021 15:11:42 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Song Liu <songliubraving@...com>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>, bpf <bpf@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: perf build broken looking for bpf/{libbpf,bpf}.h after merge
 with upstream

Em Thu, Nov 04, 2021 at 10:56:26AM -0700, Andrii Nakryiko escreveu:
> On Thu, Nov 4, 2021 at 10:49 AM Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> wrote:

> > Em Thu, Nov 04, 2021 at 02:37:57PM -0300, Arnaldo Carvalho de Melo escreveu:
> > >
> > > Hi Song,
> > >
> > >       I just did a merge with upstream and I'm getting this:
> > >
> > >   LINK    /tmp/build/perf/plugins/plugin_scsi.so
> > >   INSTALL trace_plugins
> >
> > To clarify, the command line to build perf that results in this problem
> > is:
> >
> >   make -k BUILD_BPF_SKEL=1 CORESIGHT=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin
> 
> Oh, I dropped CORESIGN and left BUILD_BPF_SKEL=1 and yeah, I see the
> build failure. I do think now that it's related to the recent Makefile
> revamp effort. Quentin, PTAL.
> 
> On the side note, why BUILD_BPF_SKEL=1 is not a default, we might have
> caught this sooner. Is there any reason not to flip the default?

I asked Song in the past about this, and asked again on another reply to
this thread, I think it should be the default.

Song, Namhyung? You're the skel guys (so far) :-)

- Arnaldo