linux-kernel - Re: [PATCH] block: fix bd_holder_dir kobject_create_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YYQ1Jd+F+2Cksyyt@bombadil.infradead.org>
Date:   Thu, 4 Nov 2021 12:31:49 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     hare@...e.de, hch@...radead.org, wubo40@...wei.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix bd_holder_dir kobject_create_and_add() error
 handling

On Thu, Nov 04, 2021 at 01:30:29PM -0600, Jens Axboe wrote:
> On 11/4/21 1:29 PM, Luis Chamberlain wrote:
> > Commit 83cbce957446 ("block: add error handling for device_add_disk /
> > add_disk") added error handling to device_add_disk(), however the goto
> > label for the bd_holder_dir kobject_create_and_add() failure did not set
> > the return value correctly, and so we can end up in a situation where
> > kobject_create_and_add() fails but we report success.
> 
> I'm just going to fold this one in, as it's top-of-tree.

Makes sense.

  Luis