linux-kernel - Re: [PATCH] KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYQ9ofrIKDxbgbu3@google.com>
Date:   Thu, 4 Nov 2021 20:08:01 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     "Durrant, Paul" <pdurrant@...zon.co.uk>
Cc:     Paul Durrant <paul@....org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] KVM: x86: Make sure KVM_CPUID_FEATURES really are
 KVM_CPUID_FEATURES

On Thu, Nov 04, 2021, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Sean Christopherson <seanjc@...gle.com>
> > Sent: 04 November 2021 19:23
> > To: Paul Durrant <paul@....org>
> > Cc: kvm@...r.kernel.org; linux-kernel@...r.kernel.org; Durrant, Paul <pdurrant@...zon.co.uk>; Paolo
> > Bonzini <pbonzini@...hat.com>; Vitaly Kuznetsov <vkuznets@...hat.com>; Wanpeng Li
> > <wanpengli@...cent.com>; Jim Mattson <jmattson@...gle.com>; Joerg Roedel <joro@...tes.org>
> > Subject: RE: [EXTERNAL] [PATCH] KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID_FEATURES
> > 
> > On Thu, Nov 04, 2021, Paul Durrant wrote:
> > > From: Paul Durrant <pdurrant@...zon.com>
> > >
> > > Currently when kvm_update_cpuid_runtime() runs, it assumes that the
> > > KVM_CPUID_FEATURES leaf is located at 0x40000001. This is not true,
> > > however, if Hyper-V support is enabled. In this case the KVM leaves will
> > > be offset.
> > >
> > > This patch introdues as new 'kvm_cpuid_base' field into struct
> > > kvm_vcpu_arch to track the location of the KVM leaves and function
> > > kvm_update_cpuid_base() (called from kvm_update_cpuid_runtime()) to locate
> > > the leaves using the 'KVMKVMKVM\0\0\0' signature. Adjustment of
> > > KVM_CPUID_FEATURES will hence now target the correct leaf.
> > >
> > > Signed-off-by: Paul Durrant <pdurrant@...zon.com>
> > > ---
> > > Cc: Paolo Bonzini <pbonzini@...hat.com>
> > > Cc: Sean Christopherson <seanjc@...gle.com>
> > > Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> > > Cc: Wanpeng Li <wanpengli@...cent.com>
> > > Cc: Jim Mattson <jmattson@...gle.com>
> > > Cc: Joerg Roedel <joro@...tes.org>
> > 
> > scripts/get_maintainer.pl is your friend :-)
> 
> That's what I used, but thought it prudent to trim the list to just KVM reviewers.

Ah, yeah, I run get_maintainer.pl with "--pattern-depth=1" when I'm sending KVM
patches/series.  That tells the script to stop recursing once its found a match.