linux-kernel - Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211105031508.GA817@LAPTOP-UKSR4ENP.internal.baidu.com>
Date:   Fri, 5 Nov 2021 11:15:08 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Xu Wang <vulab@...as.ac.cn>
CC:     <joel@....id.au>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: litex: Remove unnecessary print function
 dev_err()

On 05 11月 21 01:42:17, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
Reviewed-by: Cai Huoqing <caihuoqing@...du.com>
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> index 3d9385a4989b..ab9fa1525053 100644
> --- a/drivers/net/ethernet/litex/litex_liteeth.c
> +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> @@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
>  	priv->dev = &pdev->dev;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
> +	if (irq < 0)
>  		return irq;
> -	}
>  	netdev->irq = irq;
>  
>  	priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
> -- 
> 2.25.1
>