linux-kernel - Re: [PATCH v2] scsi: scsi_debug: don't call kcalloc if size arg is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1v917nu8o.fsf@ca-mkp.ca.oracle.com>
Date:   Thu, 04 Nov 2021 23:42:47 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     George Kennedy <george.kennedy@...cle.com>
Cc:     gregkh@...uxfoundation.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com,
        dgilbert@...erlog.com, joe@...ches.com
Subject: Re: [PATCH v2] scsi: scsi_debug: don't call kcalloc if size arg is
 zero


George,

> If the size arg to kcalloc() is zero, it returns ZERO_SIZE_PTR.
> Because of that, for a following NULL pointer check to work on the
> returned pointer, kcalloc() must not be called with the size arg equal
> to zero. Return early without error before the kcalloc() call if size
> arg is zero.

Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering