linux-kernel - Re: [PATCH v2] w1: w1_therm: use swap() to make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YYTfPhg5GKtJGB3o@kroah.com>
Date:   Fri, 5 Nov 2021 08:37:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     davidcomponentone@...il.com
Cc:     dan.carpenter@...cle.com, ivan.zaentsev@...enboard.ru,
        linux-kernel@...r.kernel.org, unixbhaskar@...il.com,
        yang.guang5@....com.cn, yangyingliang@...wei.com, zbr@...emap.net,
        zealci@....com.cn
Subject: Re: [PATCH v2] w1: w1_therm: use swap() to make code cleaner

On Fri, Nov 05, 2021 at 03:32:44PM +0800, davidcomponentone@...il.com wrote:
> From: Yang Guang <yang.guang5@....com.cn>
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Yang Guang <yang.guang5@....com.cn>
> ---
>  drivers/w1/slaves/w1_therm.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
> index ca70c5f03206..565578002d79 100644
> --- a/drivers/w1/slaves/w1_therm.c
> +++ b/drivers/w1/slaves/w1_therm.c
> @@ -1785,7 +1785,7 @@ static ssize_t alarms_store(struct device *device,
>  	u8 new_config_register[3];	/* array of data to be written */
>  	int temp, ret;
>  	char *token = NULL;
> -	s8 tl, th, tt;	/* 1 byte per value + temp ring order */
> +	s8 tl, th;	/* 1 byte per value + temp ring order */
>  	char *p_args, *orig;
>  
>  	p_args = orig = kmalloc(size, GFP_KERNEL);
> @@ -1836,9 +1836,8 @@ static ssize_t alarms_store(struct device *device,
>  	th = int_to_short(temp);
>  
>  	/* Reorder if required th and tl */
> -	if (tl > th) {
> -		tt = tl; tl = th; th = tt;
> -	}
> +	if (tl > th)
> +		swap(tl, th);
>  
>  	/*
>  	 * Read the scratchpad to change only the required bits
> -- 
> 2.30.2
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot