linux-kernel - Re: [PATCH] bus: brcmstb_gisb: Allow building as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211105081351.GA6380@alpha.franken.de>
Date:   Fri, 5 Nov 2021 09:13:51 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        linux-kernel@...ts.infradead.org,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] bus: brcmstb_gisb: Allow building as module

On Thu, Nov 04, 2021 at 07:56:12PM -0700, Florian Fainelli wrote:
> 
> 
> On 11/4/2021 7:51 PM, Guenter Roeck wrote:
> > On Fri, Sep 24, 2021 at 12:10:34PM -0700, Florian Fainelli wrote:
> > > Allow building the Broadcom STB GISB arbiter driver as a module, however
> > > similar to interrupt controller drivers, don't allow its unbind/removal
> > > since it is not quite prepared for that and we want it to catch bus
> > > errors all the time.
> > > 
> > > Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> > 
> > Hmm, did you actually test that ?
> 
> Great way to introduce someone to a problem, really.
> 
> > 
> > Building mips:allmodconfig ... failed
> > --------------
> > Error log:
> > <stdin>:1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp]
> > ERROR: modpost: "board_be_handler" [drivers/bus/brcmstb_gisb.ko] undefined!
> 
> I did not indeed test a modular build for MIPS and had not anticipated it to
> fail. Thomas, do you have any objections exporting board_be_handler to
> modules or would you rather not do it and force the driver to be boolean for
> MIPS?

I'd prefer to not export it, so making the driver non-modular for MIPS
would be a solution. If there is a need to set the bus error handling
I'd like to see a function setting and that function could be exported.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]