linux-kernel - Re: [PATCH] vdpa: Mark vdpa_config_ops.get_vq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211105083224.5tkhslrswshbynnu@steredhat>
Date:   Fri, 5 Nov 2021 09:32:24 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Eugenio Pérez <eperezma@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vdpa: Mark vdpa_config_ops.get_vq_notification as
 optional

On Thu, Nov 04, 2021 at 08:52:48PM +0100, Eugenio Pérez wrote:
>Since vhost_vdpa_mmap checks for its existence before calling it.
>
>Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
>---
> include/linux/vdpa.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
>index c3011ccda430..0bdc7f785394 100644
>--- a/include/linux/vdpa.h
>+++ b/include/linux/vdpa.h
>@@ -155,7 +155,7 @@ struct vdpa_map_file {
>  *				@vdev: vdpa device
>  *				@idx: virtqueue index
>  *				@state: pointer to returned state (last_avail_idx)
>- * @get_vq_notification:	Get the notification area for a virtqueue
>+ * @get_vq_notification:	Get the notification area for a virtqueue (optional)
>  *				@vdev: vdpa device
>  *				@idx: virtqueue index
>  *				Returns the notifcation area
>-- 
>2.27.0
>

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>