linux-kernel - Re: [PATCH] ASoC: codecs: Axe some dead code in 'wcd_mbhc_adc_hs_rem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <837b3278-ca6d-b013-03f2-e6a681886578@linaro.org>
Date:   Fri, 5 Nov 2021 09:11:00 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, yang.lee@...ux.alibaba.com
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ASoC: codecs: Axe some dead code in
 'wcd_mbhc_adc_hs_rem_irq()'



On 03/11/2021 19:19, Christophe JAILLET wrote:
> 'hphpa_on' is know to be false, so this is just dead code that should be
> removed.
> 
> Suggested-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

--srini


> ---
> This patch is a follow-up of:
> https://lore.kernel.org/kernel-janitors/988948f7f266aa00698704687537335b7e6a67b2.1634455711.git.christophe.jaillet@wanadoo.fr/
> ---
>   sound/soc/codecs/wcd-mbhc-v2.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c
> index 405128ccb4b0..b905eb8f3c67 100644
> --- a/sound/soc/codecs/wcd-mbhc-v2.c
> +++ b/sound/soc/codecs/wcd-mbhc-v2.c
> @@ -1176,7 +1176,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data)
>   	struct wcd_mbhc *mbhc = data;
>   	unsigned long timeout;
>   	int adc_threshold, output_mv, retry = 0;
> -	bool hphpa_on = false;
>   
>   	mutex_lock(&mbhc->lock);
>   	timeout = jiffies + msecs_to_jiffies(WCD_FAKE_REMOVAL_MIN_PERIOD_MS);
> @@ -1210,10 +1209,6 @@ static irqreturn_t wcd_mbhc_adc_hs_rem_irq(int irq, void *data)
>   	wcd_mbhc_elec_hs_report_unplug(mbhc);
>   	wcd_mbhc_write_field(mbhc, WCD_MBHC_BTN_ISRC_CTL, 0);
>   
> -	if (hphpa_on) {
> -		hphpa_on = false;
> -		wcd_mbhc_write_field(mbhc, WCD_MBHC_HPH_PA_EN, 3);
> -	}
>   exit:
>   	mutex_unlock(&mbhc->lock);
>   	return IRQ_HANDLED;
>