linux-kernel - Re: [PATCH 07/21] media: atmel: atmel-sama7g5-isc: fix ispck leftover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Nov 2021 10:15:55 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Eugen Hristev <eugen.hristev@...rochip.com>
Cc:     linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        laurent.pinchart@...asonboard.com, sakari.ailus@....fi,
        robh+dt@...nel.org, nicolas.ferre@...rochip.com
Subject: Re: [PATCH 07/21] media: atmel: atmel-sama7g5-isc: fix ispck leftover

Hi Eugen,

On Fri, Oct 22, 2021 at 10:52:33AM +0300, Eugen Hristev wrote:
> The ispck is not used for sama7g5 variant of the ISC.
> Calls to ispck have to be removed also from module insert/removal.
>
> Fixes: d7f26849ed7c ("media: atmel: fix the ispck initialization")
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

Reviewed-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks
   j

> ---
>  drivers/media/platform/atmel/atmel-sama7g5-isc.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> index 9c05acafd072..6a5d3f7ce75e 100644
> --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> @@ -555,7 +555,6 @@ static int microchip_xisc_remove(struct platform_device *pdev)
>
>  	v4l2_device_unregister(&isc->v4l2_dev);
>
> -	clk_disable_unprepare(isc->ispck);
>  	clk_disable_unprepare(isc->hclock);
>
>  	isc_clk_cleanup(isc);
> @@ -567,7 +566,6 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev)
>  {
>  	struct isc_device *isc = dev_get_drvdata(dev);
>
> -	clk_disable_unprepare(isc->ispck);
>  	clk_disable_unprepare(isc->hclock);
>
>  	return 0;
> @@ -582,10 +580,6 @@ static int __maybe_unused xisc_runtime_resume(struct device *dev)
>  	if (ret)
>  		return ret;
>
> -	ret = clk_prepare_enable(isc->ispck);
> -	if (ret)
> -		clk_disable_unprepare(isc->hclock);
> -
>  	return ret;
>  }
>
> --
> 2.25.1
>