linux-kernel - nfc: pn533: suspected double free when pn533_fill_fragment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYCP286MB1188FA6BE2735C22AA9C473E8A8E9@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>
Date:   Fri, 5 Nov 2021 09:22:12 +0000
From:   YE Chengfeng <cyeaa@...nect.ust.hk>
To:     "krzysztof.kozlowski@...onical.com" 
        <krzysztof.kozlowski@...onical.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "wengjianfeng@...ong.com" <wengjianfeng@...ong.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: nfc: pn533: suspected double free when pn533_fill_fragment_skbs()
 return value <= 0

Hi,

We notice that skb is already freed by dev_kfree_skb in pn533_fill_fragment_skbs, but follow error handler branch #line 2288 and #line 2356, skb is freed again, seems like a double free issue. Would you like to have a look at them? We will provide patch for them after confirmation.

https://github.com/torvalds/linux/blob/master/drivers/nfc/pn533/pn533.c#L2288

Thanks so much,
Chengfeng