linux-kernel - Re: [PATCH] staging: r8188eu: core: remove the unused variable pAdapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Nov 2021 10:56:03 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove the unused variable
 pAdapter

On Thu, Nov 04, 2021 at 08:52:42AM +0530, Saurav Girepunje wrote:
> Remove the unused variable pAdapter from Efuse_Write1ByteToFakeContent
> This variable is not used in the function.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> ---
>  drivers/staging/r8188eu/core/rtw_efuse.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> index 03c8431b2ed3..39c77f6b06ef 100644
> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> @@ -40,10 +40,7 @@ static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
>  }
> 
>  static bool
> -Efuse_Write1ByteToFakeContent(
> -			struct adapter *pAdapter,
> -			u16 Offset,
> -			u8 Value)
> +Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)s

You can do this same thing in drivers/staging/rtl8723bs/core/rtw_efuse.c
if you want to.

thanks,

greg k-h