linux-kernel - RE: [PATCH v2] um: use swap() to make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e392bf23c3ae4b93b1ffb23e40728873@AcuMS.aculab.com>
Date:   Fri, 5 Nov 2021 11:30:40 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Yang Guang' <davidcomponentone@...il.com>,
        "anton.ivanov@...bridgegreys.com" <anton.ivanov@...bridgegreys.com>
CC:     "jdike@...toit.com" <jdike@...toit.com>,
        "johannes.berg@...el.com" <johannes.berg@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
        "richard@....at" <richard@....at>,
        "yang.guang5@....com.cn" <yang.guang5@....com.cn>,
        "zealci@....com.cn" <zealci@....com.cn>
Subject: RE: [PATCH v2] um: use swap() to make code cleaner

From: Yang Guang
> Sent: 05 November 2021 06:19
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.

Is there any real point to any of these patches??

If I'm reading a 'random' piece of code I now have to assume
that swap() is something that 'magically' exchanges two items.
This requires more brain-power than parsing the three lines
that do an actual swap.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)