linux-kernel - Re: [PATCH v10] tty: Fix the keyboard led light display problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Nov 2021 21:38:13 +0800
From:   "lianzhi chang" <changlianzhi@...ontech.com>
To:     "Andy Shevchenko" 
        <andriy.shevchenko@...ux.intel.com>
Cc:     "linux-kernel" <linux-kernel@...r.kernel.org>,
        "dmitry.torokhov" <dmitry.torokhov@...il.com>,
        "Greg KH" <gregkh@...uxfoundation.org>,
        "jirislaby" <jirislaby@...nel.org>,
        "282827961" <282827961@...com>
Subject: Re: [PATCH v10] tty: Fix the keyboard led light display problem

On Fri, Nov 05, 2021 at 08:24:43PM +0800, lianzhi chang wrote:
> > Switching from the desktop environment to the tty environment,
> > the state of the keyboard led lights and the state of the keyboard
> > lock are inconsistent. This is because the attribute kb->kbdmode
> > of the tty bound in the desktop environment (Xorg) is set to
> > VC_OFF, which causes the ledstate and kb->ledflagstate
> > values of the bound tty to always be 0, which causes the switch
> > from the desktop When to the tty environment, the LED light
> > status is inconsistent with the keyboard lock status.
> > In order to ensure that the keyboard LED lights are displayed
> > normally during the VT switching process, when the VT is
> > switched, the current VT LED configuration is forced to be issued.
> >
> > Signed-off-by: lianzhi chang <changlianzhi@...ontech.com>
> > ---
> >  v10:
> >  The led state of the input device is no longer synchronized to
> >  ledstate, and the related code is deleted. The current plan is
> >  changed to: when the VT is switched, the LED state saved by the
> >  current VT is forced to be issued.
> > 
> Shouldn't you add a Suggested-by tag?

Oh, sorry, I was negligent, I will add it right away.

Thanks.
--
lianzhi chang