linux-kernel - 回复: [PATCH] HSI: core: Fix return freed object in hsi_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Nov 2021 13:46:11 +0000
From:   YE Chengfeng <cyeaa@...nect.ust.hk>
To:     "sre@...nel.org" <sre@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH] HSI: core: Fix return freed object in hsi_new_client

Hi, 

We send a patch for this suspected uaf issue. Would you like to have a look at it?

Best regards,
Chengfeng

-----邮件原件-----
发件人: YE Chengfeng 
发送时间: 2021年11月5日 21:45
收件人: sre@...nel.org
抄送: linux-kernel@...r.kernel.org; YE Chengfeng <cyeaa@...nect.ust.hk>
主题: [PATCH] HSI: core: Fix return freed object in hsi_new_client

cl is freed on error of calling device_register, but this object is return later, which will cause uaf issue. Fix it by return NULL on error.

Signed-off-by: Chengfeng Ye <cyeaa@...nect.ust.hk>
---
 drivers/hsi/hsi_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index ec90713564e3..884066109699 100644
--- a/drivers/hsi/hsi_core.c
+++ b/drivers/hsi/hsi_core.c
@@ -102,6 +102,7 @@ struct hsi_client *hsi_new_client(struct hsi_port *port,
 	if (device_register(&cl->device) < 0) {
 		pr_err("hsi: failed to register client: %s\n", info->name);
 		put_device(&cl->device);
+		goto err;
 	}
 
 	return cl;
--
2.17.1