linux-kernel - Re: [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE for ARM_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iGU5UHvZrwk4wuRNQhfJYj=HyTm=3cj8+1UyCa6dwwGw@mail.gmail.com>
Date:   Fri, 5 Nov 2021 16:26:00 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Julian Braha <julianbraha@...il.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Necip Fazil Yildiran <fazilyildiran@...il.com>
Subject: Re: [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE
 for ARM_CPU_SUSPEND

On Fri, Oct 29, 2021 at 11:52 PM Julian Braha <julianbraha@...il.com> wrote:
>
> When ARM_TEGRA_CPUIDLE or ARM_QCOM_SPM_CPUIDLE are selected,
> and ARCH_SUSPEND_POSSIBLE is disabled, Kbuild gives the
> following warnings:
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
>   Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
>   Selected by [y]:
>   - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> and
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
>   Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
>   Selected by [y]:
>   - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> This is because these options enable ARM_CPU_SUSPEND
> without selecting or depending on ARCH_SUSPEND_POSSIBLE,
> despite ARM_CPU_SUSPEND depending on ARCH_SUSPEND_POSSIBLE.
>
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if
> this is not the appropriate solution.

The changes make sense to me, but I need the maintainers of the two
affected platforms to tell me that this is OK.

> Signed-off-by: Julian Braha <julianbraha@...il.com>
> ---
>  drivers/cpuidle/Kconfig.arm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 15d6c46c0a47..1b4f5ae1ee05 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE
>  config ARM_TEGRA_CPUIDLE
>         bool "CPU Idle Driver for NVIDIA Tegra SoCs"
>         depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
> +       depends on ARCH_SUSPEND_POSSIBLE
>         select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
>         select ARM_CPU_SUSPEND
>         help
> @@ -108,6 +109,7 @@ config ARM_TEGRA_CPUIDLE
>  config ARM_QCOM_SPM_CPUIDLE
>         bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
>         depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
> +       depends on ARCH_SUSPEND_POSSIBLE
>         select ARM_CPU_SUSPEND
>         select CPU_IDLE_MULTIPLE_DRIVERS
>         select DT_IDLE_STATES
> --
> 2.30.2
>