lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Nov 2021 09:54:54 +0800 From: Joseph Qi <joseph.qi@...ux.alibaba.com> To: cgel.zte@...il.com, mark@...heh.com, akpm <akpm@...ux-foundation.org> Cc: jlbec@...lplan.org, ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org, Zhang Mingyu <zhang.mingyu@....com.cn>, Zeal Robot <zealci@....com.cn> Subject: Re: [PATCH] ocfs2:Use BUG_ON instead of if condition followed by BUG. On 11/5/21 9:44 AM, cgel.zte@...il.com wrote: > From: Zhang Mingyu <zhang.mingyu@....com.cn> > > This issue was detected with the help of Coccinelle. > > Reported-by: Zeal Robot <zealci@....com.cn> > Signed-off-by: Zhang Mingyu <zhang.mingyu@....com.cn> Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com> > --- > fs/ocfs2/journal.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c > index dbf9b9e97d74..1887a2708709 100644 > --- a/fs/ocfs2/journal.c > +++ b/fs/ocfs2/journal.c > @@ -1669,8 +1669,7 @@ static int ocfs2_replay_journal(struct ocfs2_super *osb, > status = jbd2_journal_load(journal); > if (status < 0) { > mlog_errno(status); > - if (!igrab(inode)) > - BUG(); > + BUG_ON(!igrab(inode)); > jbd2_journal_destroy(journal); > goto done; > } > @@ -1699,8 +1698,7 @@ static int ocfs2_replay_journal(struct ocfs2_super *osb, > if (status < 0) > mlog_errno(status); > > - if (!igrab(inode)) > - BUG(); > + BUG_ON(!igrab(inode)); > > jbd2_journal_destroy(journal); > >
Powered by blists - more mailing lists