linux-kernel - Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5b698db-5fc0-2d62-2b6e-4c0d70903fa0@gmail.com>
Date:   Fri, 5 Nov 2021 09:09:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Haimin Zhang <tcs.kernel@...il.com>,
        Al Cooper <alcooperx@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Haimin Zhang <tcs_kernel@...cent.com>,
        TCS Robot <tcs_robot@...cent.com>
Subject: Re: [PATCH 2/2] USB: ehci_brcm_hub_control: replace wIndex-1 with
 temp

On 11/5/21 1:52 AM, Greg KH wrote:
> On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
>> In function `ehci_brcm_hub_control`, like following code,  
>> it filters out the case where the upper byte of wIndex is nonzero, 
>> so it need be replaced with temp.
> 
> I do not understand this text, can you try to reword it?
> 
> And you have trailing whitespace.
> 
> And why use `?
> 
>> ```
> 
> What is this for?  Changelog comments are not in markdown format.
> 
>> 	if ((typeReq == GetPortStatus) &&
>> 	    (wIndex && wIndex <= ports) &&       // need to be replaced
> 
> What does this comment mean?
> 
>> 	    ehci->reset_done[wIndex-1] &&
>> 	    time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
>> 	    (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
>> ```
>>
>> Signed-off-by: Haimin Zhang <tcs_kernel@...cent.com>
>> Reported-by: TCS Robot <tcs_robot@...cent.com>
> 
> Again, lines need to be in different order, and your from: line is not
> correct.
> 
> Also, you need an individual email address, not a group email alias for
> your contributions.  We work with individuals, not groups.

Also, would you mind copying the people who are remotely involved with
this piece of code, like Al? Thank you
-- 
Florian