linux-kernel - Re: [PATCH] soc: ti: fix wkup_m3_rproc_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7A4FCE6D-292C-4E04-BAF2-03C85E94ABDF@oracle.com>
Date:   Fri, 5 Nov 2021 16:17:59 +0000
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Arnd Bergmann <arnd@...nel.org>
CC:     Santosh Shilimkar <ssantosh@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Dave Gerlach <d-gerlach@...com>,
        Tony Lindgren <tony@...mide.com>,
        "soc@...nel.org" <soc@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Lee Jones <lee.jones@...aro.org>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] soc: ti: fix wkup_m3_rproc_boot_thread return type



> On Nov 5, 2021, at 12:51 AM, Arnd Bergmann <arnd@...nel.org> wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype,
> which broke after Eric's recent cleanup:
> 
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
>  429 |         return 0;
>      |                ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
>  416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>      |             ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Change it to the normal prototype as it should have been from the
> start.
> 
> Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
> Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> —

Looks good to me. Thanks !!

Acked-by: Santosh Shilimkar <ssantosh@...nel.org>