linux-kernel - Re: [PATCH] thermal: Replace pr_warn() with pr_warn_once() in user_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85dab5a5-733b-6bfa-2ddf-ee4a2f0b7117@linaro.org>
Date:   Fri, 5 Nov 2021 17:37:32 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>
Subject: Re: [PATCH] thermal: Replace pr_warn() with pr_warn_once() in
 user_space_bind()

On 05/11/2021 17:31, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Use pr_warn_once() instead of pr_warn() to print the user space
> governor deprecation message in user_space_bind() to reduce the
> kernel log noise.
> 
> Fixes: 0275c9fb0eff ("thermal/core: Make the userspace governor deprecated")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

> ---
>  drivers/thermal/gov_user_space.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-pm/drivers/thermal/gov_user_space.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/gov_user_space.c
> +++ linux-pm/drivers/thermal/gov_user_space.c
> @@ -17,8 +17,8 @@
>  
>  static int user_space_bind(struct thermal_zone_device *tz)
>  {
> -	pr_warn("Userspace governor deprecated: use thermal netlink "	\
> -		"notification instead\n");
> +	pr_warn_once("Userspace governor deprecated: use thermal netlink " \
> +		     "notification instead\n");
>  
>  	return 0;
>  }
> 
> 
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog