linux-kernel - Re: parisc build failures in mainline kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202111051242.86E9DBF@keescook>
Date:   Fri, 5 Nov 2021 12:43:00 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ard Biesheuvel <ardb@...nel.org>, Helge Deller <deller@....de>,
        linux-parisc <linux-parisc@...r.kernel.org>
Subject: Re: parisc build failures in mainline kernel

On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote:
> On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck <linux@...ck-us.net> wrote:
> >
> > Unfortunately not. With that patch it complains about task_struct.
> 
> Gaah. You'll need something like this too
> 
> -       DEFINE(TASK_CPU, offsetof(struct task_struct, cpu));
> +       DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu));
> 
> in arch/parisc/kernel/asm-offsets.c.
> 
> And really, it should probably be renamed as TASK_TI_CPU, but then you
> have to rename all the uses too.
> 
> There might be other details like that lurking.

I'll check this out too if Ard doesn't beat me to it. Thanks for the
investigation and sorry for the breakage!

-- 
Kees Cook