linux-kernel - Re: [PATCH v1 2/2] iio: test: Add test for IIO_VAL_INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Nov 2021 04:20:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andriy Tryshnivskyy <andriy.tryshnivskyy@...nsynergy.com>,
        jbhayana@...gle.com, jic23@...nel.org
Cc:     kbuild-all@...ts.01.org, lars@...afoo.de,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vasyl.Vavrychuk@...nsynergy.com, andy.shevchenko@...il.com,
        andriy.tryshnivskyy@...nsynergy.com
Subject: Re: [PATCH v1 2/2] iio: test: Add test for IIO_VAL_INT_64.

Hi Andriy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on 7d2a07b769330c34b4deabeed939325c77a7ec2f]

url:    https://github.com/0day-ci/linux/commits/Andriy-Tryshnivskyy/iio-test-Add-test-for-IIO_VAL_INT_64/20211105-180624
base:   7d2a07b769330c34b4deabeed939325c77a7ec2f
config: arc-buildonly-randconfig-r002-20211105 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/679e11158271ed8c6219060b06dca25dce946859
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andriy-Tryshnivskyy/iio-test-Add-test-for-IIO_VAL_INT_64/20211105-180624
        git checkout 679e11158271ed8c6219060b06dca25dce946859
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/iio/test/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/test/iio-test-format.c: In function 'iio_test_iio_format_value_integer_64':
>> drivers/iio/test/iio-test-format.c:213:37: error: 'IIO_VAL_INT_64' undeclared (first use in this function); did you mean 'IIO_VAL_INT'?
     213 |         ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
         |                                     ^~~~~~~~~~~~~~
         |                                     IIO_VAL_INT
   drivers/iio/test/iio-test-format.c:213:37: note: each undeclared identifier is reported only once for each function it appears in


vim +213 drivers/iio/test/iio-test-format.c

   199	
   200	static void iio_test_iio_format_value_integer_64(struct kunit *test)
   201	{
   202		int values[2];
   203		s64 value;
   204		char *buf;
   205		int ret;
   206	
   207		buf = kunit_kmalloc(test, PAGE_SIZE, GFP_KERNEL);
   208		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
   209	
   210		value = 24;
   211		values[0] = lower_32_bits(value);
   212		values[1] = upper_32_bits(value);
 > 213		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   214		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "24\n");
   215	
   216		value = -24;
   217		values[0] = lower_32_bits(value);
   218		values[1] = upper_32_bits(value);
   219		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   220		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-24\n");
   221	
   222		value = 0;
   223		values[0] = lower_32_bits(value);
   224		values[1] = upper_32_bits(value);
   225		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   226		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "0\n");
   227	
   228		value = UINT_MAX;
   229		values[0] = lower_32_bits(value);
   230		values[1] = upper_32_bits(value);
   231		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   232		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "4294967295\n");
   233	
   234		value = -((s64)UINT_MAX);
   235		values[0] = lower_32_bits(value);
   236		values[1] = upper_32_bits(value);
   237		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   238		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-4294967295\n");
   239	
   240		value = LLONG_MAX;
   241		values[0] = lower_32_bits(value);
   242		values[1] = upper_32_bits(value);
   243		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   244		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "9223372036854775807\n");
   245	
   246		value = LLONG_MIN;
   247		values[0] = lower_32_bits(value);
   248		values[1] = upper_32_bits(value);
   249		ret = iio_format_value(buf, IIO_VAL_INT_64, ARRAY_SIZE(values), values);
   250		IIO_TEST_FORMAT_EXPECT_EQ(test, buf, ret, "-9223372036854775808\n");
   251	}
   252	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26599 bytes)