linux-kernel - Re: [PATCH] crypto: qce: fix uaf on qce_skcipher_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a158429-6eed-bbcb-f4d0-a6db8ba40d58@linaro.org>
Date:   Fri, 5 Nov 2021 17:12:04 -0400
From:   Thara Gopinath <thara.gopinath@...aro.org>
To:     Chengfeng Ye <cyeaa@...nect.ust.hk>, herbert@...dor.apana.org.au,
        davem@...emloft.net, svarbanov@...sol.com
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] crypto: qce: fix uaf on qce_skcipher_register_one



On 11/4/21 9:46 AM, Chengfeng Ye wrote:
> Pointer alg points to sub field of tmpl, it
> is dereferenced after tmpl is freed. Fix
> this by accessing alg before free tmpl.
> 
> Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
> Signed-off-by: Chengfeng Ye <cyeaa@...nect.ust.hk>

Acked-by: Thara Gopinath <thara.gopinath@...aro.org>

> ---
>   drivers/crypto/qce/skcipher.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c
> index 8ff10928f581..3d27cd5210ef 100644
> --- a/drivers/crypto/qce/skcipher.c
> +++ b/drivers/crypto/qce/skcipher.c
> @@ -484,8 +484,8 @@ static int qce_skcipher_register_one(const struct qce_skcipher_def *def,
>   
>   	ret = crypto_register_skcipher(alg);
>   	if (ret) {
> -		kfree(tmpl);
>   		dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);
> +		kfree(tmpl);
>   		return ret;
>   	}
>   
> 

-- 
Warm Regards
Thara (She/Her/Hers)