linux-kernel - Re: [PATCH v3] staging: vt6655: fix camelcase byData in card.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfa9d7734dfc64263b30f29b4d23aab7d0683089.camel@perches.com>
Date:   Sat, 06 Nov 2021 12:06:30 -0700
From:   Joe Perches <joe@...ches.com>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: fix camelcase byData in card.c

On Sat, 2021-11-06 at 19:48 +0100, Tommaso Merciai wrote:
> Replace camelcase variable "byData" into linux kernel coding style
> equivalent variable "data" in card.c.
> "by" prefix in hungarian notation stands for byte or unsigned char
[]
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
[]
> @@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
>  			priv->abyBBVGA[0] = 0x20;
>  			priv->abyBBVGA[2] = 0x10;
>  			priv->abyBBVGA[3] = 0x10;
> -			bb_read_embedded(priv, 0xE7, &byData);
> -			if (byData == 0x1C)
> +			bb_read_embedded(priv, 0xE7, &data);

It might be nice to figure out what these register values are
and use #defines instead of hard coded values like 0xE7

> +			if (data == 0x1C)
>  				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);

etc...