linux-kernel - [krzk-github:n/devfreq-exynos-ppmu-node-names 2895/2969] drivers/hwmon/max6620.c:236:2: warning: unannotated fall-through between switch labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 7 Nov 2021 05:48:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [krzk-github:n/devfreq-exynos-ppmu-node-names 2895/2969]
 drivers/hwmon/max6620.c:236:2: warning: unannotated fall-through between
 switch labels

tree:   https://github.com/krzk/linux n/devfreq-exynos-ppmu-node-names
head:   6ebcb485d3543204ba45a4158eabcc51e966e464
commit: 8c1b0feea4fecc11f2dd2fa37481fc63562a2cb6 [2895/2969] Merge branch 'hwmon-next' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
config: i386-randconfig-a016-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/krzk/linux/commit/8c1b0feea4fecc11f2dd2fa37481fc63562a2cb6
        git remote add krzk-github https://github.com/krzk/linux
        git fetch --no-tags krzk-github n/devfreq-exynos-ppmu-node-names
        git checkout 8c1b0feea4fecc11f2dd2fa37481fc63562a2cb6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/hwmon/max6620.c:236:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   drivers/hwmon/max6620.c:236:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break; 
   1 warning generated.


vim +236 drivers/hwmon/max6620.c

a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  218  
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  219  static umode_t
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  220  max6620_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  221  		   int channel)
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  222  {
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  223  	switch (type) {
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  224  	case hwmon_fan:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  225  		switch (attr) {
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  226  		case hwmon_fan_alarm:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  227  		case hwmon_fan_input:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  228  			return 0444;
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  229  		case hwmon_fan_div:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  230  		case hwmon_fan_target:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  231  			return 0644;
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  232  		default:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  233  			break;
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  234  		}
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  235  
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13 @236  	default:
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  237  		break;
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  238  	}
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  239  
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  240  	return 0;
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  241  }
a2ff27ef3c770c Arun Saravanan Balachandran 2021-09-13  242  

:::::: The code at line 236 was first introduced by commit
:::::: a2ff27ef3c770c2d86ca8e5160b9aff08323be1a hwmon: Add Maxim MAX6620 hardware monitoring driver

:::::: TO: Arun Saravanan Balachandran <Arun_Saravanan_Balac@...l.com>
:::::: CC: Guenter Roeck <linux@...ck-us.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35379 bytes)