lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Nov 2021 23:08:57 -0300 From: Enzo Matsumiya <ematsumiya@...e.de> To: linux-nvme@...ts.infradead.org Cc: Enzo Matsumiya <ematsumiya@...e.de>, Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, linux-kernel@...r.kernel.org Subject: [RFC PATCH] nvme: add NO APST quirk for Kioxia device This particular Kioxia device times out and aborts I/O during any load, but it's more easily observable with discards (fstrim). The device gets to a state that is also not possible to use "nvme set-feature" to disable APST. Booting with nvme_core.default_ps_max_latency=0 solves the issue. We had a dozen or so of these behaving this same way on customer environment. Signed-off-by: Enzo Matsumiya <ematsumiya@...e.de> --- drivers/nvme/host/core.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 838b5e2058be..a698c099164c 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2469,7 +2469,19 @@ static const struct nvme_core_quirk_entry core_quirks[] = { .vid = 0x14a4, .fr = "22301111", .quirks = NVME_QUIRK_SIMPLE_SUSPEND, - } + }, + { + /* + * This Kioxia device times out and aborts I/O during any load, + * but more easily reproducible with discards (fstrim). + * + * Device is left in a state that is also not possible to use "nvme set-feature" + * to disable APST, but booting with nvme_core.default_ps_max_latency=0 works. + */ + .vid = 0x1e0f, + .mn = "KCD6XVUL6T40", + .quirks = NVME_QUIRK_NO_APST, + } }; /* match is null-terminated but idstr is space-padded. */ -- 2.33.0
Powered by blists - more mailing lists