linux-kernel - Re: [RFC PATCH] mips: BCM63XX: select CPU_SUPPORTS_32BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <249707d6-660f-99ce-b7d3-c48dc7209bbe@gmail.com>
Date:   Fri, 5 Nov 2021 20:31:56 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...r.kernel.org,
        Paul Burton <paulburton@...nel.org>,
        Maxime Bizon <mbizon@...ebox.fr>,
        Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [RFC PATCH] mips: BCM63XX: select CPU_SUPPORTS_32BIT_KERNEL



On 11/5/2021 7:58 PM, Randy Dunlap wrote:
> 
> Several header files need info on CONFIG_32BIT or CONFIG_64BIT,
> but kconfig symbol BCM63XX does not provide that info. This leads
> to many build errors, e.g.:
> 
>     arch/mips/include/asm/page.h:196:13: error: use of undeclared identifier 'CAC_BASE'
>             return x - PAGE_OFFSET + PHYS_OFFSET;
>     arch/mips/include/asm/mach-generic/spaces.h:91:23: note: expanded from macro 'PAGE_OFFSET'
>     #define PAGE_OFFSET             (CAC_BASE + PHYS_OFFSET)
>     arch/mips/include/asm/io.h:134:28: error: use of undeclared identifier 'CAC_BASE'
>             return (void *)(address + PAGE_OFFSET - PHYS_OFFSET);
>     arch/mips/include/asm/mach-generic/spaces.h:91:23: note: expanded from macro 'PAGE_OFFSET'
>     #define PAGE_OFFSET             (CAC_BASE + PHYS_OFFSET)
> 
> arch/mips/include/asm/uaccess.h:82:10: error: use of undeclared identifier '__UA_LIMIT'
>             return (__UA_LIMIT & (addr | (addr + size) | __ua_size(size))) == 0;
> 
> 
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: bcm-kernel-feedback-list@...adcom.com
> Cc: linux-mips@...r.kernel.org
> Cc: Paul Burton <paulburton@...nel.org>
> Cc: Maxime Bizon <mbizon@...ebox.fr>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> ---
> Note: I did see a bunch of build errors like this one:
> ../arch/mips/kernel/r4k_fpu.S:217: Error: opcode not supported on this processor: mips1 (mips1) `ldc1 $f24,192($4)'
> but I'm hoping/guessing that this is due to not having a proper compiler
> for the BCM63xx target.
> 
>   arch/mips/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- linux-next-20211105.orig/arch/mips/Kconfig
> +++ linux-next-20211105/arch/mips/Kconfig
> @@ -329,6 +329,7 @@ config BCM63XX
>   	select SYNC_R4K
>   	select DMA_NONCOHERENT
>   	select IRQ_MIPS_CPU
> +	select CPU_SUPPORTS_32BIT_KERNEL

That's one option, the other could be to add:

         select SYS_HAS_CPU_BMIPS32_3300
         select SYS_HAS_CPU_BMIPS4350
         select SYS_HAS_CPU_BMIPS4380

Which would ensure that CPU_SUPPORTS_32BIT_KERNEL is selected AFAICT. 
Can you try that? What config file did you use to produce that build 
error BTW?
-- 
Florian