linux-kernel - Re: [RFC PATCH 1/4] stop_machine: Move cpu_stop_done into stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALOAHbArZ90h8yn4mzQhBDEwStA6eNffXx1K=E=Wro61AvDkGA@mail.gmail.com>
Date:   Sat, 6 Nov 2021 15:30:49 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Benjamin Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/4] stop_machine: Move cpu_stop_done into stop_machine.h

On Sat, Nov 6, 2021 at 1:01 AM Valentin Schneider
<valentin.schneider@....com> wrote:
>
> On 04/11/21 14:57, Yafang Shao wrote:
> > Move struct cpu_stop_done into the stop_machine.h, then it can be resued
> > by the functions outside of stop_maichine.c.
> >
>
> The nr_todo & ret faff is only required for multi_stop scenarios, which
> isn't your use-case. AFAICT you don't need to export this, you just need a
> struct completion somewhere (and maybe a ret, but I'm not even sure about
> that).

Right. nr_todo is for stopping two and more cpus.  We really don't
need it if we only support stopping one cpu.
I will change it.

-- 
Thanks
Yafang