lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Nov 2021 15:58:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Valentin Schneider <valentin.schneider@....com>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection

Hi Valentin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/master]
[also build test ERROR on linus/master next-20211106]
[cannot apply to linux/master v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ea79c24a30aa27ccc4aac26be33f8b73f3f1f59c
config: x86_64-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/4731291127aa2100c984229a91533b671044a74b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Valentin-Schneider/sched-Tweak-default-dynamic-preempt-mode-selection/20211105-184135
        git checkout 4731291127aa2100c984229a91533b671044a74b
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/core.c:3439:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
    3439 | void sched_set_stop_task(int cpu, struct task_struct *stop)
         |      ^~~~~~~~~~~~~~~~~~~
   In file included from <command-line>:
   kernel/sched/core.c: In function 'sched_dynamic_update':
>> include/linux/static_call_types.h:15:34: error: '__SCT__might_resched' undeclared (first use in this function); did you mean '__SCT__cond_resched'?
      15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__
         |                                  ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                  ^~~~~~~
   include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:154:10: note: in expansion of macro 'STATIC_CALL_TRAMP'
     154 |  typeof(&STATIC_CALL_TRAMP(name)) __F = (func);   \
         |          ^~~~~~~~~~~~~~~~~
   kernel/sched/core.c:6575:2: note: in expansion of macro 'static_call_update'
    6575 |  static_call_update(might_resched, __cond_resched);
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/static_call_types.h:15:34: note: each undeclared identifier is reported only once for each function it appears in
      15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__
         |                                  ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                  ^~~~~~~
   include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:154:10: note: in expansion of macro 'STATIC_CALL_TRAMP'
     154 |  typeof(&STATIC_CALL_TRAMP(name)) __F = (func);   \
         |          ^~~~~~~~~~~~~~~~~
   kernel/sched/core.c:6575:2: note: in expansion of macro 'static_call_update'
    6575 |  static_call_update(might_resched, __cond_resched);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/tracepoint.h:22,
                    from include/trace/events/sched.h:10,
                    from kernel/sched/core.c:10:
   include/linux/static_call.h:154:41: warning: initialization of 'int' from 'int (*)(void)' makes integer from pointer without a cast [-Wint-conversion]
     154 |  typeof(&STATIC_CALL_TRAMP(name)) __F = (func);   \
         |                                         ^
   kernel/sched/core.c:6575:2: note: in expansion of macro 'static_call_update'
    6575 |  static_call_update(might_resched, __cond_resched);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from <command-line>:
>> include/linux/static_call_types.h:9:33: error: '__SCK__might_resched' undeclared (first use in this function); did you mean '__SCK__cond_resched'?
       9 | #define STATIC_CALL_KEY_PREFIX  __SCK__
         |                                 ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:12:32: note: in expansion of macro '__PASTE'
      12 | #define STATIC_CALL_KEY(name)  __PASTE(STATIC_CALL_KEY_PREFIX, name)
         |                                ^~~~~~~
   include/linux/static_call_types.h:12:40: note: in expansion of macro 'STATIC_CALL_KEY_PREFIX'
      12 | #define STATIC_CALL_KEY(name)  __PASTE(STATIC_CALL_KEY_PREFIX, name)
         |                                        ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:155:24: note: in expansion of macro 'STATIC_CALL_KEY'
     155 |  __static_call_update(&STATIC_CALL_KEY(name),   \
         |                        ^~~~~~~~~~~~~~~
   kernel/sched/core.c:6575:2: note: in expansion of macro 'static_call_update'
    6575 |  static_call_update(might_resched, __cond_resched);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/tracepoint.h:22,
                    from include/trace/events/sched.h:10,
                    from kernel/sched/core.c:10:
   include/linux/static_call.h:156:39: warning: passing argument 3 of '__static_call_update' makes pointer from integer without a cast [-Wint-conversion]
     156 |         STATIC_CALL_TRAMP_ADDR(name), __F); \
         |                                       ^~~
         |                                       |
         |                                       int
   kernel/sched/core.c:6575:2: note: in expansion of macro 'static_call_update'
    6575 |  static_call_update(might_resched, __cond_resched);
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:177:82: note: expected 'void *' but argument is of type 'int'
     177 | extern void __static_call_update(struct static_call_key *key, void *tramp, void *func);
         |                                                                            ~~~~~~^~~~
   In file included from <command-line>:
   include/linux/static_call_types.h:15:34: error: '__SCT__preempt_schedule' undeclared (first use in this function)
      15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__
         |                                  ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                  ^~~~~~~
   include/linux/static_call_types.h:18:42: note: in expansion of macro 'STATIC_CALL_TRAMP_PREFIX'
      18 | #define STATIC_CALL_TRAMP(name)  __PASTE(STATIC_CALL_TRAMP_PREFIX, name)
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:154:10: note: in expansion of macro 'STATIC_CALL_TRAMP'
     154 |  typeof(&STATIC_CALL_TRAMP(name)) __F = (func);   \
         |          ^~~~~~~~~~~~~~~~~
   kernel/sched/core.c:6576:2: note: in expansion of macro 'static_call_update'
    6576 |  static_call_update(preempt_schedule, __preempt_schedule_func);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/tracepoint.h:22,
                    from include/trace/events/sched.h:10,
                    from kernel/sched/core.c:10:
   kernel/sched/core.c:6576:39: error: '__preempt_schedule_func' undeclared (first use in this function); did you mean 'preempt_schedule_irq'?
    6576 |  static_call_update(preempt_schedule, __preempt_schedule_func);
         |                                       ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:154:42: note: in definition of macro 'static_call_update'
     154 |  typeof(&STATIC_CALL_TRAMP(name)) __F = (func);   \
         |                                          ^~~~
   In file included from <command-line>:
   include/linux/static_call_types.h:9:33: error: '__SCK__preempt_schedule' undeclared (first use in this function)
       9 | #define STATIC_CALL_KEY_PREFIX  __SCK__
         |                                 ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:12:32: note: in expansion of macro '__PASTE'
      12 | #define STATIC_CALL_KEY(name)  __PASTE(STATIC_CALL_KEY_PREFIX, name)
         |                                ^~~~~~~
   include/linux/static_call_types.h:12:40: note: in expansion of macro 'STATIC_CALL_KEY_PREFIX'
      12 | #define STATIC_CALL_KEY(name)  __PASTE(STATIC_CALL_KEY_PREFIX, name)
         |                                        ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:155:24: note: in expansion of macro 'STATIC_CALL_KEY'
     155 |  __static_call_update(&STATIC_CALL_KEY(name),   \
         |                        ^~~~~~~~~~~~~~~
   kernel/sched/core.c:6576:2: note: in expansion of macro 'static_call_update'
    6576 |  static_call_update(preempt_schedule, __preempt_schedule_func);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/tracepoint.h:22,
                    from include/trace/events/sched.h:10,
                    from kernel/sched/core.c:10:
   include/linux/static_call.h:156:39: warning: passing argument 3 of '__static_call_update' makes pointer from integer without a cast [-Wint-conversion]
     156 |         STATIC_CALL_TRAMP_ADDR(name), __F); \
         |                                       ^~~
         |                                       |
         |                                       int
   kernel/sched/core.c:6576:2: note: in expansion of macro 'static_call_update'
    6576 |  static_call_update(preempt_schedule, __preempt_schedule_func);
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/static_call.h:177:82: note: expected 'void *' but argument is of type 'int'
     177 | extern void __static_call_update(struct static_call_key *key, void *tramp, void *func);
         |                                                                            ~~~~~~^~~~
   In file included from <command-line>:
   include/linux/static_call_types.h:15:34: error: '__SCT__preempt_schedule_notrace' undeclared (first use in this function)
      15 | #define STATIC_CALL_TRAMP_PREFIX __SCT__
         |                                  ^~~~~~~
   include/linux/compiler_types.h:59:23: note: in definition of macro '___PASTE'
      59 | #define ___PASTE(a,b) a##b
         |                       ^
   include/linux/static_call_types.h:18:34: note: in expansion of macro '__PASTE'


vim +15 include/linux/static_call_types.h

115284d89a436e Josh Poimboeuf 2020-08-18   8  
115284d89a436e Josh Poimboeuf 2020-08-18  @9  #define STATIC_CALL_KEY_PREFIX		__SCK__
9183c3f9ed710a Josh Poimboeuf 2020-08-18  10  #define STATIC_CALL_KEY_PREFIX_STR	__stringify(STATIC_CALL_KEY_PREFIX)
9183c3f9ed710a Josh Poimboeuf 2020-08-18  11  #define STATIC_CALL_KEY_PREFIX_LEN	(sizeof(STATIC_CALL_KEY_PREFIX_STR) - 1)
115284d89a436e Josh Poimboeuf 2020-08-18  12  #define STATIC_CALL_KEY(name)		__PASTE(STATIC_CALL_KEY_PREFIX, name)
73f44fe19d3596 Josh Poimboeuf 2021-01-27  13  #define STATIC_CALL_KEY_STR(name)	__stringify(STATIC_CALL_KEY(name))
115284d89a436e Josh Poimboeuf 2020-08-18  14  
115284d89a436e Josh Poimboeuf 2020-08-18 @15  #define STATIC_CALL_TRAMP_PREFIX	__SCT__
115284d89a436e Josh Poimboeuf 2020-08-18  16  #define STATIC_CALL_TRAMP_PREFIX_STR	__stringify(STATIC_CALL_TRAMP_PREFIX)
9183c3f9ed710a Josh Poimboeuf 2020-08-18  17  #define STATIC_CALL_TRAMP_PREFIX_LEN	(sizeof(STATIC_CALL_TRAMP_PREFIX_STR) - 1)
115284d89a436e Josh Poimboeuf 2020-08-18  18  #define STATIC_CALL_TRAMP(name)		__PASTE(STATIC_CALL_TRAMP_PREFIX, name)
115284d89a436e Josh Poimboeuf 2020-08-18  19  #define STATIC_CALL_TRAMP_STR(name)	__stringify(STATIC_CALL_TRAMP(name))
115284d89a436e Josh Poimboeuf 2020-08-18  20  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29938 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ