linux-kernel - Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle smatch-warnings in method vt_do_kdgkb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHP4M8UXCb_6tAqDAZuKSUO=Y=U4wAk1C8v-MJbDCPOAV9+tFg@mail.gmail.com>
Date:   Sun, 7 Nov 2021 08:51:29 +0530
From:   Ajay Garg <ajaygargnsit@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        andriy.shevchenko@...ux.intel.com, kernel@...il.dk,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle
 smatch-warnings in method vt_do_kdgkb_ioctl

> >
>
> I am not against these braces, but I, honestly, dislike them, because
> `case : {` syntax looks ugly _to me_.
>
> KDGKBSENT uses it because of local variable `len` and not using them
> will cause build error.

Ahh, that explains the difference.

Floated the v4 patch at :
https://lore.kernel.org/linux-serial/20211107031721.4734-1-ajaygargnsit@gmail.com/T/#u

so that consistency is maintained in the styling.

Let's continue on the v4-patch link now.

Thanks again Pavel.


>
> I didn't find any strict requirements to not use brackets when there is
> no local variable, so it's up to maintainers (again).
>
>
> Anyway, thank for respinning :)
>
>
>
> With regards,
> Pavel Skripkin