linux-kernel - Re: [PATCH v2] staging: r8188eu: Fix breakage introduced when 5G code was removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Nov 2021 17:43:57 +0000
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Zameer Manji <zmanji@...il.com>,
        kernel test robot <lkp@...el.com>,
        Stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2] staging: r8188eu: Fix breakage introduced when 5G code
 was removed

On Sun, 7 Nov 2021 at 17:35, Larry Finger <Larry.Finger@...inger.net> wrote:
>
> In commit 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions
> and code"), two entries were removed from RTW_ChannelPlanMap[], but not replaced
> with zeros. The position within this table is important, thus the patch broke
> systems operating in regulatory domains osted later than entry 0x13 in the table.
> Unfortunately, the FCC entry comes before that point and most testers did not see
> this problem.
>
> Reported-and-tested-by: Zameer Manji <zmanji@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions and code")
> Cc: Stable <stable@...r.kernel.org> # v5.5+
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>
> v2 - fixed use of () rsther than {} - found by kernel test robot
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 55c3d4a6faeb..5b60e6df5f87 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -107,6 +107,7 @@ static struct rt_channel_plan_map   RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = {
>         {0x01}, /* 0x10, RT_CHANNEL_DOMAIN_JAPAN */
>         {0x02}, /* 0x11, RT_CHANNEL_DOMAIN_FCC_NO_DFS */
>         {0x01}, /* 0x12, RT_CHANNEL_DOMAIN_JAPAN_NO_DFS */
> +       {0x00}, /* 0x13 */
>         {0x02}, /* 0x14, RT_CHANNEL_DOMAIN_TAIWAN_NO_DFS */
>         {0x00}, /* 0x15, RT_CHANNEL_DOMAIN_ETSI_NO_DFS */
>         {0x00}, /* 0x16, RT_CHANNEL_DOMAIN_KOREA_NO_DFS */
> @@ -118,6 +119,7 @@ static struct rt_channel_plan_map   RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = {
>         {0x00}, /* 0x1C, */
>         {0x00}, /* 0x1D, */
>         {0x00}, /* 0x1E, */
> +       {0x00}, /* 0x1F, */
>         /*  0x20 ~ 0x7F , New Define ===== */
>         {0x00}, /* 0x20, RT_CHANNEL_DOMAIN_WORLD_NULL */
>         {0x01}, /* 0x21, RT_CHANNEL_DOMAIN_ETSI1_NULL */
> --
> 2.33.1
>

Reviewed-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil