linux-kernel - Re: [PATCH] staging: rtl8192u: remove the if condition without effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24befb64-0fdc-03ab-5a9a-c7be443be1a1@gmail.com>
Date:   Mon, 8 Nov 2021 09:45:05 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     gregkh@...uxfoundation.org, kuba@...nel.org, lee.jones@...aro.org,
        nathan@...nel.org, clrrm@...p.ipp.pt, johan@...nel.org,
        dinghao.liu@....edu.cn, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: rtl8192u: remove the if condition without effect



On 08/11/21 9:41 am, Saurav Girepunje wrote:
> In function rtl8192_adapter_start priv->pFirmware->firmware_status
> is assign to FW_STATUS_0_INIT just after assignment variable is
> again get check for same value. Therefore if condition will be
> always be true. So remove the if condition ,else if section and
> else section which will never get execute.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 726d7ad9408b..f5d9e81f4ac7 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -2666,14 +2666,7 @@ static bool rtl8192_adapter_start(struct net_device *dev)
>  	/* config CPUReset Register */
>  	/* Firmware Reset or not? */
>  	read_nic_dword(dev, CPU_GEN, &dwRegRead);
> -	if (priv->pFirmware->firmware_status == FW_STATUS_0_INIT)
> -		dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
> -	else if (priv->pFirmware->firmware_status == FW_STATUS_5_READY)
> -		dwRegRead |= CPU_GEN_FIRMWARE_RESET;
> -	else
> -		RT_TRACE(COMP_ERR,
> -			 "ERROR in %s(): undefined firmware state(%d)\n",
> -			 __func__,   priv->pFirmware->firmware_status);
> +	dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
> 
>  	write_nic_dword(dev, CPU_GEN, dwRegRead);
>  	/* config BB. */
> --
> 2.33.0
> 

read_nic_dword function call also does not update value of priv->pFirmware->firmware_status.
read_nic_dword return a value that never check by any caller function.
That can cover on another patch.

Regards,
Saurav