linux-kernel - [RFC PATCH] PM: axp20x_ocv_values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211108052141.GA10523@9d7d69d1eba2>
Date:   Mon, 8 Nov 2021 13:21:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Marangoni <thomas.marangoni@....at>, sre@...nel.org,
        wens@...e.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Thomas Marangoni <thomas.marangoni@....at>
Subject: [RFC PATCH] PM: axp20x_ocv_values_uV[] can be static

drivers/power/supply/axp20x_battery.c:105:11: warning: symbol 'axp20x_ocv_values_uV' was not declared. Should it be static?
drivers/power/supply/axp20x_battery.c:1004:1: warning: symbol 'dev_attr_voltage_low_alert_level1' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---
 axp20x_battery.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c
index 5997c8192c73e..ec17841d51733 100644
--- a/drivers/power/supply/axp20x_battery.c
+++ b/drivers/power/supply/axp20x_battery.c
@@ -102,7 +102,7 @@ struct axp20x_batt_ps {
  * OCV curve has fixed values and percentage can be adjusted, this array represents
  * the fixed values in uV
  */
-const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
+static const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
 	3132800,
 	3273600,
 	3414400,
@@ -1001,7 +1001,7 @@ static ssize_t voltage_low_alert_level1_store(struct device *dev,
 	return count;
 }
 
-DEVICE_ATTR_RW(voltage_low_alert_level1);
+static DEVICE_ATTR_RW(voltage_low_alert_level1);
 
 static ssize_t voltage_low_alert_level2_show(struct device *dev,
 					     struct device_attribute *attr,