linux-kernel - Re: [PATCH 06/15] usb: typec: fusb302: Fix masking of comparator and bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYj3f9nAFjZzbgJp@kuha.fi.intel.com>
Date:   Mon, 8 Nov 2021 12:10:07 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Ondřej Jirman <megous@...ous.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Badhri Jagan Sridharan <badhri@...gle.com>,
        "open list:USB TYPEC PORT CONTROLLER DRIVERS" 
        <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/15] usb: typec: fusb302: Fix masking of comparator and
 bc_lvl interrupts

Hi,

On Mon, Nov 08, 2021 at 10:25:23AM +0100, Ondřej Jirman wrote:
> On Mon, Nov 08, 2021 at 09:10:31AM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Nov 07, 2021 at 07:57:24PM +0100, Ondřej Jirman wrote:
> > > Hi,
> > > 
> > > On Sun, Nov 07, 2021 at 07:54:33PM +0100, megous hlavni wrote:
> > > > The masks are swapped (interrupts are enabled when the mask is 0).
> > > 
> > > Please ignore the 06/15 in the subject. This is just a single patch
> > > from my local series and I forgot to edit the subject.
> > 
> > But I see 2 patches sent in this series?
> 
> The other one is unrelated. This patch is a fix for a real bug.

If this fixes a bug, then please include the appropriate Fixes tag and
CC stable@...r.kernel.org. I'm guessing this is what the Fixes tag
should look like:

        Fixes: 48242e30532b ("usb: typec: fusb302: Revert "Resolve fixed power role contract setup"")

You probable also want to CC Hans de Goede <hdegoede@...hat.com> since
you are patching his code.

> The other seemed like an independent correctness issue that I noticed from code
> review I had to do to figure out the reason for failure to handle disconnect
> detection properly. It's unrelated to this patch other than touching the same driver.

It still says "PATCH 07/15..." which means it's a part of a series,
no? So..

> > Can you just fix this up and resend them correctly?

thanks,

-- 
heikki