linux-kernel - [PATCH v0 27/42] bus: brcmstb_gisb: Check notifier registration return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211108101157.15189-28-bp@alien8.de>
Date:   Mon,  8 Nov 2021 11:11:42 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     bcm-kernel-feedback-list@...adcom.com
Subject: [PATCH v0 27/42] bus: brcmstb_gisb: Check notifier registration return value

From: Borislav Petkov <bp@...e.de>

Avoid homegrown notifier registration checks.

No functional changes.

Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: bcm-kernel-feedback-list@...adcom.com
---
 drivers/bus/brcmstb_gisb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
index 4c2f7d61cb9b..1c0180ebe6a7 100644
--- a/drivers/bus/brcmstb_gisb.c
+++ b/drivers/bus/brcmstb_gisb.c
@@ -490,8 +490,10 @@ static int __init brcmstb_gisb_arb_probe(struct platform_device *pdev)
 
 	if (list_is_singular(&brcmstb_gisb_arb_device_list)) {
 		register_die_notifier(&gisb_die_notifier);
-		atomic_notifier_chain_register(&panic_notifier_list,
-					       &gisb_panic_notifier);
+
+		if (atomic_notifier_chain_register(&panic_notifier_list,
+						   &gisb_panic_notifier))
+			pr_warn("GISB Panic notifier already registered\n");
 	}
 
 	dev_info(&pdev->dev, "registered irqs: %d, %d\n",
-- 
2.29.2