linux-kernel - Re: [PATCH nf-next v6] netfilter: ipvs: Fix reuse connection if RS weight is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YYkAGcPu0yIQ6WnN@salvia>
Date:   Mon, 8 Nov 2021 11:46:49 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Simon Horman <horms@...ge.net.au>
Cc:     yangxingwu <xingwu.yang@...il.com>, ja@....bg,
        kadlec@...filter.org, fw@...len.de, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        corbet@....net, Chuanqi Liu <legend050709@...com>
Subject: Re: [PATCH nf-next v6] netfilter: ipvs: Fix reuse connection if RS
 weight is 0

On Thu, Nov 04, 2021 at 03:04:04PM +0100, Simon Horman wrote:
> On Thu, Nov 04, 2021 at 11:10:29AM +0800, yangxingwu wrote:
> > We are changing expire_nodest_conn to work even for reused connections when
> > conn_reuse_mode=0, just as what was done with commit dc7b3eb900aa ("ipvs:
> > Fix reuse connection if real server is dead").
> > 
> > For controlled and persistent connections, the new connection will get the
> > needed real server depending on the rules in ip_vs_check_template().
> > 
> > Fixes: d752c3645717 ("ipvs: allow rescheduling of new connections when port reuse is detected")
> > Co-developed-by: Chuanqi Liu <legend050709@...com>
> > Signed-off-by: Chuanqi Liu <legend050709@...com>
> > Signed-off-by: yangxingwu <xingwu.yang@...il.com>
> 
> Acked-by: Simon Horman <horms@...ge.net.au>
> 
> (v5 was acked by Julian, probably that can be propagated here)
> 
> Pablo, please consider this for nf-next at your convenience.

Applied this fix to nf, thanks.