linux-kernel - Re: [PATCH] sched: Tweak default dynamic preempt mode selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rxyeu26.mognet@arm.com>
Date:   Mon, 08 Nov 2021 12:00:17 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [PATCH] sched: Tweak default dynamic preempt mode selection

On 06/11/21 13:05, kernel test robot wrote:
>    kernel/sched/core.c:3439:6: error: no previous prototype for function 'sched_set_stop_task' [-Werror,-Wmissing-prototypes]
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>         ^
>    kernel/sched/core.c:3439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void sched_set_stop_task(int cpu, struct task_struct *stop)
>    ^
>    static
>>> kernel/sched/core.c:6576:2: error: use of undeclared identifier '__SCT__preempt_schedule'
>            static_call_update(preempt_schedule, __preempt_schedule_func);
>            ^

Doh, I broke the

  PREEMPT_DYNAMIC
    select PREEMPT

thing - the above happens with PREEMPT_DYNAMIC && !PREEMPT. Lemme fix.