linux-kernel - Re: [PATCH] amt: add IPV6 Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bcfd0b5-ceb3-f397-36c1-8365dcbb769c@gmail.com>
Date:   Mon, 8 Nov 2021 21:39:10 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Loic Poulain <loic.poulain@...aro.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] amt: add IPV6 Kconfig dependency

Hi Arnd,

On 11/8/21 8:12 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This driver cannot be built-in if IPV6 is a loadable module:
> 
> x86_64-linux-ld: drivers/net/amt.o: in function `amt_build_mld_gq':
> amt.c:(.text+0x2e7d): undefined reference to `ipv6_dev_get_saddr'
> 
> Add the idiomatic Kconfig dependency that all such modules
> have.
> 
> Fixes: b9022b53adad ("amt: add control plane of amt interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 034dbd487c33..10506a4b66ef 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -294,6 +294,7 @@ config GTP
>   config AMT
>   	tristate "Automatic Multicast Tunneling (AMT)"
>   	depends on INET && IP_MULTICAST
> +	depends on IPV6 || !IPV6
>   	select NET_UDP_TUNNEL
>   	help
>   	  This allows one to create AMT(Automatic Multicast Tunneling)
> 

Acked-by: Taehee Yoo <ap420073@...il.com>