linux-kernel - Re: [PATCH v3 6/6] drm: Make the nomodeset message less sensational

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07d75447-eaa2-ec12-a1b2-d1ca2d7013ad@suse.de>
Date:   Mon, 8 Nov 2021 13:50:09 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Pekka Paalanen <pekka.paalanen@...labora.com>,
        Jani Nikula <jani.nikula@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Michel Dänzer <michel@...nzer.net>,
        dri-devel@...ts.freedesktop.org,
        Peter Robinson <pbrobinson@...il.com>
Subject: Re: [PATCH v3 6/6] drm: Make the nomodeset message less sensational

Hi

Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas:
> The message printed when nomodeset is present in the kernel command line
> makes it look as if the parameter must never be used and it's a bad idea.
> 
> But there are valid reasons to use this parameter and the message should
> not imply otherwise. Change the text to be more accurate and restrained.
> 
> Suggested-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
> 
> (no changes since v1)
> 
>   drivers/gpu/drm/drm_nomodeset.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git drivers/gpu/drm/drm_nomodeset.c drivers/gpu/drm/drm_nomodeset.c
> index fc3acf3ab2e2..45e50b3497b8 100644
> --- drivers/gpu/drm/drm_nomodeset.c
> +++ drivers/gpu/drm/drm_nomodeset.c
> @@ -15,9 +15,7 @@ static int __init disable_modeset(char *str)
>   {
>   	drm_nomodeset = true;
>   
> -	pr_warn("You have booted with nomodeset. This means your GPU drivers are DISABLED\n");
> -	pr_warn("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n");
> -	pr_warn("Unless you actually understand what nomodeset does, you should reboot without enabling it\n");
> +	pr_warn("Booted with the nomodeset parameter. Graphics drivers will not be loaded\n");

Same issue as with patch 5. Rather say something like

   Booted with the nomodeset parameter. Only the system framebuffer will 
be available.

Best regards
Thomas

>   
>   	return 1;
>   }
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)