linux-kernel - Re: [RFC v4 2/6] mmc: core: allow to match the device tree to apply quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8874B3D3-E2D1-4743-B9B6-F2FD3EB4033F@goldelico.com>
Date:   Mon, 8 Nov 2021 17:01:01 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Avri Altman <avri.altman@....com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        Bean Huo <beanhuo@...ron.com>,
        Gražvydas Ignotas <notasas@...il.com>,
        linux-mmc@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, kernel@...a-handheld.com
Subject: Re: [RFC v4 2/6] mmc: core: allow to match the device tree to apply
 quirks



> Am 08.11.2021 um 16:34 schrieb Jérôme Pouiller <jerome.pouiller@...abs.com>:
> 
> On Monday 8 November 2021 16:00:02 CET Ulf Hansson wrote:
>> On Sat, 6 Nov 2021 at 15:31, H. Nikolaus Schaller <hns@...delico.com> wrote:
>>> 
>>> Hi Jérôme,
>>> 
>>>> Am 05.11.2021 um 15:27 schrieb Jérôme Pouiller <jerome.pouiller@...abs.com>:
>>>> 
>>>> On Friday 5 November 2021 10:05:47 CET H. Nikolaus Schaller wrote:
>>>>> From: Jérôme Pouiller <jerome.pouiller@...abs.com>
>>>>> 
>>>>> MMC subsystem provides a way to apply quirks when a device match some
>>>>> properties (VID, PID, etc...) Unfortunately, some SDIO devices does not
>>>>> comply with the SDIO specification and does not provide reliable VID/PID
>>>>> (eg. Silabs WF200).
>>>>> 
>>>>> So, the drivers for these devices rely on device tree to identify the
>>>>> device.
>>>>> 
>>>>> This patch allows the MMC to also rely on the device tree to apply a
>>>>> quirk.
>>>>> 
>>>>> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>
> 
> [...]
> 
>>>>> ---
>>>>> drivers/mmc/core/card.h   |  3 +++
>>>>> drivers/mmc/core/quirks.h | 17 +++++++++++++++++
>>>>> 2 files changed, 20 insertions(+)
>>>>> 
>>>>> +static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
>>>>> +                                                const char *const *compat_list)
>> 
>> After a second thought, I am not sure we really need a list of
>> compatibles here. The quirks we may want to apply should be specific
>> per device and most likely not shared among a family of devices, don't
>> you think?
> 
> Indeed. I dislike to have to declare a list of compatible device (see 
> wl1251_compatible_list in patch 5) outside of the fixup list.
> 
> If I have several devices, I prefer to copy-paste a few lines in the 
> mmc_fixup list (for the WFX driver, I have 4 devices to declare).

Agreed. It makes the macro easier to use.

BR and thanks,
Nikolaus